Tâche #23615
Scénario #23526: Epic 6 : Déployer la configuration sur les serveurs
Homogénéiser les messages SaltStack
Description
- D’après la documentation les descriptions doivent être en français
- Certains messages utilisent le paramètre
servernamealors qu’il s’agit d’un patron de sélection des minions - Tous les exemples d’utilisations ne sont pas utilisables
- L’ordre des paramètres ne reflètent pas leur importance (par example v1.execution.salt.exec et cela se reflète dans les options des méthodes
- Certains messages utilisent le paramètre
JobIdalors que les retours de commandes SaltStack utilisentjid
Associated revisions
SaltStack: error “reason” parameter must be in camel case
As required by the documentation.
Ref: #23615
SaltStack: fix curl examples
- “execution.” prefix was missing
- parameters are not passed in a sub dictionary
The examples are not usable as-is since we require authentication and
the hostname must be the public name of the machine.
Ref: #23615
SaltStack: use minion's response “jid” as requests parameter
To make requests more coherent with responses use the same term to
describe the ID of a job.
Rename affetcted parameters and error URIs.
Ref: #23615
SaltStack: jobs excetion names must be fully camel case
As required by the documentation.
- services/saltmaster/src/salt_ctrl/salt_jobs.py: “Jobid” must be
spelled “JobId".
- services/saltmaster/src/salt_ctrl/controller: ditoo.
Ref: #23615
SaltStack: rename “execution.salt.exec” parameters
- “servername” is a pattern to select minion, rename it to
“minion_pattern”
- parameters does not need to be prefixed by “salt_”
Ref: #23615
SaltStack: make sources more readable
- services/saltmaster/src/salt_ctrl/controller: add some spacing.
- services/saltmaster/src/salt_ctrl/salt_exec.py: add some spacing,
fix some alignment and format exception message when used.
- services/saltmaster/src/salt_ctrl/salt_jobs.py: add some spacing.
Ref: #23615
SaltStack: cleanup some jobs strings
- services/saltmaster/src/salt_ctrl/salt_jobs.py: fix a docstring and
an exception message.
Ref: #23615
SaltStack: notification URI must be more visible
This makes the sources more readable.
- services/saltmaster/src/salt_ctrl/controller: use keyword argument
“notification_uri” when registering.
Ref: #23615
SaltStack: fix return types and descriptions
- services/common/messages/v1/execution.salt.exec.command-executed.yml:
the “return” is a list of mapping.
- services/common/messages/v1/execution.salt.exec.yml: the description
must explain that the result is a list.
- services/common/messages/v1/execution.salt.jobs.describe.yml: the
“jobs” is a list of mapping.
Fix spelling to be clearer.
Ref: #23615
SaltStack: “execution.salt.exec” must reference proper error message
- services/common/messages/v1/execution.salt.exec.yml (errors):
“servername” was renamed as “minion_pattern”.
Ref: #23615
SaltStack: message arguments of type “String” can't be “null”
- services/common/messages/v1/execution.salt.exec.yml: “Args” default
value is the empty string.
“Client_Mode” default value is “local_async”.
Ref: #23615
SaltStack: “Minion_Pattern” is not an ID
- services/common/messages/v1/execution.salt.exec.yml: explain that
“Minion_Pattern” is a globbing pattern.
Ref: #23615
SaltStack: message argument description should be short
- services/common/messages/v1/execution.salt.exec.yml: use “help” to
explain that the pattern is in glob format.
List possible values of “Client_Mode”.
Ref: #23615
SaltStack: message description are french sentences
Starts them by a capital and ends by a dot.
Ref: #23615
History
#1 Updated by Daniel Dehennin almost 5 years ago
- Description updated (diff)
#2 Updated by Scrum Master almost 5 years ago
- Status changed from Nouveau to En cours
#3 Updated by Scrum Master almost 5 years ago
- Assigned To set to Daniel Dehennin
#4 Updated by Daniel Dehennin almost 5 years ago
- % Done changed from 0 to 100
#5 Updated by Scrum Master almost 5 years ago
- Status changed from En cours to Résolu
#6 Updated by Daniel Dehennin almost 5 years ago
- Status changed from Résolu to En cours
#7 Updated by Daniel Dehennin almost 5 years ago
- Status changed from En cours to Résolu
#8 Updated by Daniel Dehennin almost 5 years ago
- Remaining (hours) changed from 4.0 to 0.25
#9 Updated by Daniel Dehennin almost 5 years ago
- Status changed from Résolu to Fermé
- Remaining (hours) changed from 0.25 to 0.0