Anomalie #1991
redirection en boucle sur eole-web
Description
La valeur de web_redirection est à "/" par défaut :
<variable name='web_redirection' type='string' description='Application web par défaut (redirection)' > <value>/</value> </variable>
Dans le template nous avons :
%if %%is_defined('activer_envole') and %%activer_envole == 'oui' RewriteRule ^/$ %%alias_envole [R=permanent] %else RewriteRule ^/$ %%web_redirection [R=permanent] %end if
Ce qui signifie que la ligne sera :
RewriteRule ^/$ / [R=permanent]
(si on demande / on renvoi vers ... /).
Il faudrait faire un test pour éviter la redirection en boucle :
-- Vhost.conf.old 2011-08-25 08:49:32.533349685 +0200 +++ Vhost.conf 2011-08-25 08:54:58.433022085 +0200 @@ -7,8 +7,12 @@ ErrorLog /var/log/apache2/error.log RewriteEngine On %if %%is_defined('activer_envole') and %%activer_envole == 'oui' + %if %%alias_envole != '/' RewriteRule ^/$ %%alias_envole [R=permanent] + %end if %else + %if %%web_redirection != '/' RewriteRule ^/$ %%web_redirection [R=permanent] + %end if %end if </VirtualHost> --- Vhost-ssl.conf.old 2011-08-25 08:50:23.000750923 +0200 +++ Vhost-ssl.conf 2011-08-25 08:53:46.867051833 +0200 @@ -12,9 +12,13 @@ ServerName %%nom_machine RewriteEngine On %if %%is_defined('activer_envole') and %%activer_envole == 'oui' + %if %%alias_envole != '/' RewriteRule ^/$ %%alias_envole [R=permanent] + %end if %else + %if %%web_redirection != '/' RewriteRule ^/$ %%web_redirection [R=permanent] + %end if %end if # <Location /> # Order Allow,Deny
De plus, je ne comprends pas bien pourquoi le template est si compliqué. alias_envole et web_redirection sont les mêmes variables. Pourquoi ne pas jouer avec les redefines ?
Associated revisions
see #1991 Add new ldap fields
see #1991 : add import_externalauth_users right
see #1991 First work on ldap user import from ticket form
see #1991 Fix ldap search issues
see #1991 Fix ldap import
see #1991 Add missing file and new checks for popup
see #1991 Display criterias 2 per line (like autoreport)
see #1991 Fix basedn retrieval
see #1991 Improvements + correct ldapImportUSerByServerId call
see #1991 Add interface expert mode
see #1991 Improve ldap link
see #1991 Improve last commit
see #1991 Look for user with phone and email in user dropdown
see #1991 Improve search GUI
see #1991 Improve GUI
see #1991 Use session to store data instead of $_REQUEST
see #1991 Improve previous commit
see #1991 Fix basedn search criteria
see #1991 Remove addldapuser.php page
see #1991 Add basedn option when searching in expert mode + clean code
see #1991 Fix bugs + add is_default to glpi_authldaps
see #1991 Fix right issues
prise en compte du risque de redirection web en boucle (fixes #1991)
History
#1 Updated by Joël Cuissinat over 11 years ago
- Target version set to Mises à jour 2.3 - 02 RC
#2 Updated by Joël Cuissinat over 11 years ago
- Status changed from Nouveau to Résolu
- % Done changed from 0 to 100
Appliqué par commit 78d90dd8150c498fdaefefa9694d5175ab6bf910.
#3 Updated by Joël Cuissinat over 11 years ago
- Status changed from Résolu to Fermé
- Distribution set to EOLE 2.3
root@horusng:~# echo $web_redirection / root@horusng:~# grep RewriteRule /usr/share/eole/creole/distrib/Vhost*.conf /usr/share/eole/creole/distrib/Vhost.conf: RewriteRule ^/$ %%alias_envole [R=permanent] /usr/share/eole/creole/distrib/Vhost.conf: RewriteRule ^/$ %%web_redirection [R=permanent] /usr/share/eole/creole/distrib/Vhost-ssl.conf: RewriteRule ^/$ %%alias_envole [R=permanent] /usr/share/eole/creole/distrib/Vhost-ssl.conf: RewriteRule ^/$ %%web_redirection [R=permanent] root@horusng:~# grep RewriteRule /etc/apache2/sites-enabled/Vhost*.conf root@horusng:~#